patch(integration_test_charm.yaml): Skip Allure if test collection fails #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `collect-integration-tests` fails, the Allure report will be empty This will cause the next report to lose history of the previous reports For example: Before failure: https://canonical.github.io/mysql-operator/2536/ Failure: https://canonical.github.io/mysql-operator/2538/ After failure: https://canonical.github.io/mysql-operator/2543/
|
@taurus-forever which behavior is preferred—(current) empty allure report if collection fails & history is cleared (shows up on next report) or (this PR) skip the report & history on next report works (missing the skipped report)? |
|
After discussion with @taurus-forever, better to have visibility if collection fails & lose history in latest report (still available on older reports) than to hide issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
collect-integration-testsfails, the Allure report will be emptyThis will cause the next report to lose history of the previous reports
For example:
Before failure: https://canonical.github.io/mysql-operator/2536/ Failure: https://canonical.github.io/mysql-operator/2538/ After failure: https://canonical.github.io/mysql-operator/2543/