compatible: add clean-up microceph #125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest commit ce3f223 moved github_secrets/_plugin.py to python_github_secrets/_plugin.py but missed one update in the pyproject.toml, adding it
pytest runs in the host, whereas the workloads run in lxd containers. This commit allows to set the microceph URL to the host, instead of localhost.
As seen in this run: https://github.com/canonical/opensearch-operator/actions/runs/7519231326/job/20467598269 Microceph gets installed as it is a fixture needed by some tests. Even if we move all microceph-related fixtures to module and run only one non-backup test module, microceph still gets installed. This change makes microceph information a LazyMapping, that only really installs microceph once it is actually asked for some information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for microceph clean-up routine at the end of the testing. Also, add an option for keeping microceph running, if we want to use it for some extra manual tests after running an integration test.
This PR also fixes some other smaller issues.
Bug-fixes: #122, #123, #124