Skip to content

Commit

Permalink
Remove charmcraftst124
Browse files Browse the repository at this point in the history
  • Loading branch information
carlcsaposs-canonical committed Dec 20, 2024
1 parent 094257f commit cd58963
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/build_charm.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,3 @@ platforms:
Under the charmcraft.yaml `platforms` key, `build-on` and `build-for` syntax are not supported

The `base` and `bases` charmcraft.yaml keys are not supported

> [!NOTE]
> ST124 will be implemented in a future version of charmcraft. Until then, use charmcraftcache or [charmcraftst124](https://github.com/canonical/charmcraftst124) if you need to pack an ST124 charm outside of CI.

3 changes: 1 addition & 2 deletions .github/workflows/build_charm.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,6 @@ jobs:
poetry config warnings.export false
pipx install charmcraftcache
pipx install charmcraftst124
- run: snap list
- name: Pack charm
id: pack
Expand All @@ -146,7 +145,7 @@ jobs:
then
sg lxd -c "charmcraftcache pack -v --platform='${{ matrix.platform.name }}'"
else
sg lxd -c "charmcraftst124 pack -v --platform='${{ matrix.platform.name }}'"
sg lxd -c "charmcraft pack -v --platform='${{ matrix.platform.name }}'"
fi
env:
# Used by charmcraftcache (to avoid GitHub API rate limit)
Expand Down

0 comments on commit cd58963

Please sign in to comment.