Skip to content

Commit

Permalink
patch(release_*.yaml): Fix comment in docs
Browse files Browse the repository at this point in the history
  • Loading branch information
carlcsaposs-canonical committed Jan 17, 2025
1 parent 90077c9 commit 70ab2b9
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/release_charm.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
secrets:
charmhub-token: ${{ secrets.CHARMHUB_TOKEN }}
permissions:
contents: write # Needed to create GitHub release
contents: write # Needed to create git tags
```
### metadata.yaml required
Expand All @@ -44,4 +44,4 @@ With "unified charmcraft.yaml syntax", charmcraft extracts the data back into ac
Benefits of separate files:
- no difference in files between source repository and *.charm artifact that would be confusing to developers
- comments in YAML files retained
- charmcraft just copies the files into the *.charm artifact, instead of using more complicated logic to extract that information (which would create more surface area for bugs)
- charmcraft just copies the files into the *.charm artifact, instead of using more complicated logic to extract that information (which would create more surface area for bugs)
2 changes: 1 addition & 1 deletion .github/workflows/release_rock.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
artifact-prefix: ${{ needs.build.outputs.artifact-prefix }}
permissions:
packages: write # Needed to publish to GitHub Container Registry
contents: write # Needed to create GitHub release
contents: write # Needed to create git tags
```
Grant package `Write` role to GitHub Actions for the source GitHub repository: https://docs.github.com/en/packages/learn-github-packages/configuring-a-packages-access-control-and-visibility#ensuring-workflow-access-to-your-package
2 changes: 1 addition & 1 deletion .github/workflows/release_snap.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
secrets:
snap-store-token: ${{ secrets.SNAP_STORE_TOKEN }}
permissions:
contents: write # Needed to create GitHub release
contents: write # Needed to create git tags
```
`SNAP_STORE_TOKEN` should be generated with `SNAPCRAFT_STORE_AUTH=candid` (e.g. `SNAPCRAFT_STORE_AUTH=candid snapcraft export-login`)

0 comments on commit 70ab2b9

Please sign in to comment.