Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt builds on arm64 workers #7

Merged
merged 9 commits into from
Feb 20, 2024
Merged

Attempt builds on arm64 workers #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
544ad2f
Attempt builds on arm64 workers
addyess Feb 13, 2024
e83328b
Test only arm64
addyess Feb 13, 2024
85ce2aa
reintroduce the amd64 worker
addyess Feb 13, 2024
96371c7
correctly identify amd64 worker labels
addyess Feb 13, 2024
68c6208
assemble multiarch with different workflow branch
addyess Feb 13, 2024
0371e00
Ignore self-hosted runners
addyess Feb 14, 2024
9e383e3
reintroduce trivy scan
addyess Feb 14, 2024
08d2dba
Push trivy results on push
addyess Feb 14, 2024
aa32474
Apply suggestions from code review
addyess Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/pull_request.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,15 @@ jobs:
trivy-image-config: "trivy.yaml"
multiarch-awareness: true
cache-action: ${{ (github.event_name == 'push') && 'save' || 'restore' }}
platform-labels: '{"arm64": ["Ubuntu_ARM64_4C_16G_01"]}'
scan-images:
uses: canonical/k8s-workflows/.github/workflows/scan_images.yaml@main
needs: [build-and-push-arch-specifics]
secrets: inherit
with:
upload-result: ${{ github.event_name == 'push' }}
images: ${{ needs.build-and-push-arch-specifics.outputs.images }}
trivy-image-config: ./trivy.yaml
build-and-push-multiarch-manifest:
name: Combine Rocks and Push Multiarch Manifest
uses: canonical/k8s-workflows/.github/workflows/assemble_multiarch_image.yaml@main
Expand Down
3 changes: 1 addition & 2 deletions rockcraft.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ base: bare
build-base: [email protected]
platforms:
amd64:
# TODO: Add after workflows support bulding arm64 ROCKs
# arm64:
arm64:

services:
coredns:
Expand Down
Loading