Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hooks(core22): do not remove libapt for now #284

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

Meulengracht
Copy link
Member

@Meulengracht Meulengracht commented Nov 18, 2024

See #283 and the comment for the change.

I don't think its the right choice for the snapcraft snap to be importing this. On Chisel there will be no apt environment at all, and they cannot even assume any apt presence. I think we should file a bug for snapcraft to stop importing this, or atleast make them resistent to this. (See canonical/snapcraft#5146)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@Meulengracht Meulengracht linked an issue Nov 18, 2024 that may be closed by this pull request
@Meulengracht Meulengracht changed the title hooks: do not remove libapt for now hooks(core22): do not remove libapt for now Nov 18, 2024
Copy link
Member

@alfonsosanchezbeato alfonsosanchezbeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@Meulengracht Meulengracht merged commit 080a1a3 into canonical:core22 Nov 18, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest core22 snap breaks snapcraft
2 participants