Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPE-3086] Improve CI/CD pipeline #26

Merged
merged 2 commits into from
Jan 22, 2024
Merged

[DPE-3086] Improve CI/CD pipeline #26

merged 2 commits into from
Jan 22, 2024

Conversation

deusebio
Copy link
Contributor

@deusebio deusebio commented Dec 13, 2023 •
edited
Loading

I noticed that in Kafka CI/CD pipeline, we have been currently publishing wrong tags, that are not according to the standard provided as company.

While fixing this, I also provided some upgrades we did in Spark rock image to:

  • make sure that versions and release branching names are consistent
  • add extra labels to the image such that we can track a bit better which code originated the image

zmraul
zmraul approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@zmraul zmraul left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is general improvement, I think you can also remove yq block from trivy.yaml CI.

@zmraul zmraul mentioned this pull request Jan 22, 2024
Merged
@deusebio deusebio merged commit b561713 into 3-22.04 Jan 22, 2024
8 checks passed
@deusebio deusebio deleted the dpe-3086-improve-cicd branch January 22, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmraul zmraul zmraul approved these changes

@marcoppenheimer marcoppenheimer marcoppenheimer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deusebio @marcoppenheimer @zmraul