Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve fiveg_core_gnb interface schema #206

Merged
merged 4 commits into from
Dec 10, 2024
Merged

chore: improve fiveg_core_gnb interface schema #206

merged 4 commits into from
Dec 10, 2024

Conversation

dariofaccin
Copy link
Contributor

@dariofaccin dariofaccin commented Dec 2, 2024 •
edited
Loading

This PR aims to improve the schema of the fiveg_core_gnb interface.
In particular:

  • improve regex validation for mcc and mnc to avoid strings longer than 3;
  • replace cu_name with gnb-name in the databag

patriciareinoso
patriciareinoso approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@patriciareinoso patriciareinoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just update the description to gnb-name

@tonyandrewmeyer tonyandrewmeyer merged commit eea8223 into canonical:main Dec 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyandrewmeyer tonyandrewmeyer tonyandrewmeyer approved these changes

@patriciareinoso patriciareinoso patriciareinoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dariofaccin @tonyandrewmeyer @patriciareinoso