Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Integrate UATs to full-bundle-tests.yaml #739

Merged
merged 16 commits into from
Dec 13, 2023
Merged

ci: Integrate UATs to full-bundle-tests.yaml #739

merged 16 commits into from
Dec 13, 2023

Conversation

orfeas-k
Copy link
Contributor

@orfeas-k orfeas-k commented Nov 13, 2023 •
edited
Loading

This PR integrates the UATs to full-bundle-tests.yaml workflow. The PR should be merged alongside canonical/charmed-kubeflow-uats#56. Note that at the moment, the training-integration UAT will fail on self-hosted runners due to canonical/charmed-kubeflow-uats#50.

  • Update tests-bundle/1.8
  • Unpin juju in tests-bundle/1.8.
  • Refactor workflow to use Aproxy, Python 3.8 and operator action
  • Add UATs to workflow
  • Add save debug artifacts to workflow

Fixes canonical/charmed-kubeflow-uats#7

Testing the action

In order to see the action live, you could go to Actions > Deploy bundle and run UATs on self-hosted runners on this repo and trigger it with the following settings:

  • branch: kf-4343-integrate-uats-to-kubeflow-bundle-ci
  • test folder: tests-bundle/1.8
  • channel: --channel=1.8/stable
  • uats branch: kf-4343-trustenv-false-lightkube
  • microk8s channel: 1.25-strict/stable (or w/e you wish)
  • Juju channel: 3.1/stable

@orfeas-k orfeas-k force-pushed the kf-4343-integrate-uats-to-kubeflow-bundle-ci branch 3 times, most recently from a5f79c2 to e71ff75 Compare November 16, 2023 16:16
@orfeas-k
tests: Update 1.8/tests
b1d5d79 
- Remove dex-auth from the first assertion since this will be waiting
  for oidc-gatekeeper relation data
- Remove argo-server since this is not part of the bundle anymore
- Adjust timeout and idle_period since download now takes a lot less and
  big idle_period makes charms flaky since charms are active but go into
  maintenance status during this period.
@orfeas-k
tests-bundle(requirements): Unpin juju in 1.8 tests
5186d31
@orfeas-k
ci: Setup Aproxy in full-bundle-tests
581ac52
@orfeas-k
ci: Setup Python 3.8 in full-bundle-tests
e21651f
@orfeas-k
ci: Use operator actions to setup environment
106b24c
@orfeas-k
ci: Add UATs to full-bundle-tests workflow
3462c11
@orfeas-k orfeas-k force-pushed the kf-4343-integrate-uats-to-kubeflow-bundle-ci branch from eb9521c to 78b219f Compare November 23, 2023 07:47
@orfeas-k orfeas-k changed the title [WIP] ci: Integrate UATs to CI ci: Integrate UATs to full-bundle-tests.yaml Nov 23, 2023
@orfeas-k orfeas-k marked this pull request as ready for review November 23, 2023 08:44
@orfeas-k orfeas-k requested a review from a team as a code owner November 23, 2023 08:44
This was referenced Nov 23, 2023
Closed
Closed
@orfeas-k orfeas-k force-pushed the kf-4343-integrate-uats-to-kubeflow-bundle-ci branch from 78b219f to 963f611 Compare November 23, 2023 12:05
NohaIhab
NohaIhab reviewed Nov 24, 2023
View reviewed changes
Copy link
Contributor

@NohaIhab NohaIhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @orfeas-k
some small comments

.github/workflows/full-bundle-tests.yaml Show resolved Hide resolved
.github/workflows/full-bundle-tests.yaml Show resolved Hide resolved
tests-bundle/1.8/requirements.txt Outdated Show resolved Hide resolved
tests-bundle/1.8/test_release_1-8.py Outdated Show resolved Hide resolved
@orfeas-k
review: Adress comments
8f81209
@orfeas-k
scripts: Add get_release_from_bundle_source
88f4c2d 
Add a script that extracts the release from bundle-source input, in the
format that it's expected to have for full-bundle-tests.yaml workflow.
@orfeas-k
ci: Extract bundle test path from bundle source in full_bundle_tests WF
56e878b 
Use get_release_from_bundle_source script in full_bundle_tests.yaml
workflow. This way, workflow doesn't require a bundle_test_path as
input.
@NohaIhab
Copy link
Contributor

the changes LGTM
I followed the testing instructions and I'm seeing httpx.ProxyError: 403 Forbidden repeatedly.
full logs here
Is something possibly missing from the proxy setup?

@orfeas-k orfeas-k enabled auto-merge (squash) December 4, 2023 08:19
@NohaIhab
Copy link
Contributor

NohaIhab commented Dec 4, 2023

to answer my comment above, I was running the UATs from the wrong branch, because we needed the fix in canonical/charmed-kubeflow-uats#56
The PR is merged now so we can run the action on the main branch of the UATs.
I then tried to run the action but it was complaining about async tests, so I added the pytest async mark in a branch to test if it is needed, and seems that it is now needed.
With the async mark, the test failed for a different reason, the deployment was not complete waiting on argo-controller in maintenace with the message Reconciling charm: executing component kubernetes:auth-crds-cm-and-secrets

We don't have to address these issues in this PR, but they are blocking me from testing the action. WDYT? @orfeas-k

@orfeas-k
Copy link
Contributor Author

@NohaIhab Created the issue #788 documenting the flakiness of the workflow. Lmk if you think I missed something.

NohaIhab
NohaIhab approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@NohaIhab NohaIhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, we can merge this and keep in mind to address the filed issues

@orfeas-k orfeas-k merged commit 5e46102 into main Dec 13, 2023
@orfeas-k orfeas-k deleted the kf-4343-integrate-uats-to-kubeflow-bundle-ci branch December 13, 2023 09:58
@orfeas-k orfeas-k mentioned this pull request Feb 2, 2024
Merged
@orfeas-k orfeas-k mentioned this pull request Feb 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimwnasptd kimwnasptd kimwnasptd left review comments

@NohaIhab NohaIhab NohaIhab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate the UATs into the Kubeflow bundle CI on self-hosted runners
3 participants
@orfeas-k @NohaIhab @kimwnasptd