Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AKS and EKS action to properly run on schedule #1125

Merged
merged 11 commits into from
Nov 18, 2024

Conversation

mvlassis
Copy link
Contributor

@mvlassis mvlassis commented Oct 25, 2024

Closes #1124.

This PR updates the deploy-to-aks.yaml and deploy-to-eks.yaml files to properly run on schedule.

The current issue that we had to overcome is explained here

To fix this issue, I have condensed the 2 jobs into 1 job that always run, and the if statements are located inside run

Note that there is an issue when writing multiline strings to $GITHUB_OUTPUT, and that's why we run tr to remove all newline characters from the JSON output of yq.

@mvlassis mvlassis requested a review from a team as a code owner October 25, 2024 13:53
@mvlassis mvlassis changed the title Update bundle version JSON Update AKS and EKS action to properly run on schedule Nov 14, 2024
Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good already, small comments.

.github/workflows/deploy-to-aks.yaml Show resolved Hide resolved
.github/workflows/deploy-to-aks.yaml Show resolved Hide resolved
orfeas-k
orfeas-k previously approved these changes Nov 18, 2024
Copy link

@rgildein rgildein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested only the usage of checkout v4 and that was addressed, re-approving, since it was approved by @orfeas-k.

@mvlassis mvlassis merged commit ba8dce5 into main Nov 18, 2024
4 checks passed
@mvlassis mvlassis deleted the kf-6500-fix-aks-eks-workflow-dispatch branch November 18, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AKS/EKS action is failing when called via workflow_dispatch
3 participants