Do not re-use connections

Processor Edition In order to avoid stale connections to Salesforce and files.com, do not re-use those connections (the clients) and rather create new client connections when needed. Issue: #177 Signed-off-by: Nicolas Bock <[email protected]>
canonical · Sep 13, 2024 · b7287c5 · b7287c5
1 parent 0fa3247
commit b7287c5
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/cmd/processor/main.go b/cmd/processor/main.go
@@ -56,7 +56,10 @@ func main() {
 		panic(err)
 	}
 
-	p, err := processor.NewProcessor(filesClient, sfClient, natsClient, cfg, nil)
+	salesforceClientFactory := &common.BaseSalesforceClientFactory{}
+	filesComClientFactory := &common.BaseFilesComClientFactory{}
+
+	p, err := processor.NewProcessor(filesClient, sfClient, filesComClientFactory, salesforceClientFactory, natsClient, cfg, nil)
 	if err != nil {
 		panic(err)
 	}

diff --git a/pkg/processor/processor.go b/pkg/processor/processor.go
@@ -118,7 +118,7 @@ func (runner *ReportRunner) UploadAndSaveReport(report *ReportToExecute, caseNum
 	log.Debugf("Fetching files for path '%s' from db", filePath)
 	result := runner.Db.Where("path = ?", filePath).First(&file)
 	if result.Error != nil {
-		return fmt.Errorf("File not found with path '%s' in database", filePath)
+		return fmt.Errorf("file not found with path '%s' in database", filePath)
 	}
 
 	log.Infof("Fetching case with number '%s' from Salesforce", caseNumber)
@@ -363,7 +363,8 @@ func NewBaseSubscriber(filesClient common.FilesComClient, salesforceClient commo
 			AutoAck:  false,
 			JSON:     true,
 			Deadline: defaultHandlerDeadline,
-		}, Reports: reports,
+		},
+		Reports: reports,
 	}
 
 	subscriber.FilesComClient = filesClient
@@ -376,6 +377,7 @@ func NewBaseSubscriber(filesClient common.FilesComClient, salesforceClient commo
 }
 
 func NewProcessor(filesClient common.FilesComClient, salesforceClient common.SalesforceClient,
+	filesComClientFactory common.FilesComClientFactory, salesforceClientFactory common.SalesforceClientFactory,
 	provider pubsub.Provider, cfg *config.Config, dbConn *gorm.DB) (*Processor, error) {
 	var err error
 	if dbConn == nil {

diff --git a/pkg/processor/processor_test.go b/pkg/processor/processor_test.go
@@ -52,7 +52,7 @@ func (s *ProcessorTestSuite) TestRunProcessor() {
 	salesforceClient := test.SalesforceClient{}
 
 	provider := &memory.MemoryProvider{}
-	processor, _ := NewProcessor(&filesComClient, &salesforceClient, provider, s.config, s.db)
+	processor, _ := NewProcessor(&filesComClient, &salesforceClient, &test.FilesComClientFactory{}, &test.SalesforceClientFactory{}, provider, s.config, s.db)
 
 	ctx, cancel := context.WithTimeout(context.Background(), 1*time.Second)
 	defer cancel()