Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop the --ondate option of "status" #3508

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Conversation

ptoscano
Copy link
Contributor

After the recent simplification of the "status" command, checks for the subscription/compliance status at arbitrary dates are no more supported, and thus the --ondate option was no more used.

Because of that, drop the --ondate option altogether.

Card ID: CCT-1158.

After the recent simplification of the "status" command, checks for the
subscription/compliance status at arbitrary dates are no more supported,
and thus the --ondate option was no more used.

Because of that, drop the --ondate option altogether.

Card ID: CCT-1158.
Copy link

Coverage

Coverage (computed on Fedora latest) •
FileStmtsMissCoverMissing
subscription_manager/cli_command
   status.py210100% 
TOTAL17392447174% 

Tests Skipped Failures Errors Time
2413 14 💤 0 ❌ 0 🔥 30.977s ⏱️

@jsefler
Copy link
Contributor

jsefler commented Feb 13, 2025

From a functional QE perspective, this pull request satisfies...

  • the --ondate option has been removed from the status module command line options
  • bash completions for the --ondate are gone
  • the man page description for the --ondate option has been removed

PR approved by me.

Copy link
Contributor

@m-horky m-horky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@m-horky
Copy link
Contributor

m-horky commented Feb 17, 2025

Rawhide tests are failing on unrelated error (systemd package dependencies are mismatched). Merging.

@m-horky m-horky merged commit 96b120f into main Feb 17, 2025
23 of 25 checks passed
@m-horky m-horky deleted the ptoscano/drop-status-ondate branch February 17, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants