Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update HGNC license #267

Merged
merged 1 commit into from
Sep 29, 2023
Merged

feat: update HGNC license #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gene/etl/hgnc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,8 +341,8 @@ def _add_meta(self) -> None:
"Source metadata unavailable -- was data properly acquired before attempting to load DB?"
)
metadata = SourceMeta(
data_license="custom",
data_license_url="https://www.genenames.org/about/",
data_license="CC0",
data_license_url="https://www.genenames.org/about/license/",
version=self._version,
data_url={"complete_set_archive": self._data_url},
rdp_url=None,
Expand Down
8 changes: 5 additions & 3 deletions tests/unit/test_hgnc_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -837,9 +837,11 @@ def test_no_match(hgnc):
def test_meta_info(hgnc):
"""Test that the meta field is correct."""
resp = hgnc.search("HGNC:37133")
assert resp.source_meta_.data_license == "custom"
assert resp.source_meta_.data_license_url == "https://www.genenames.org/about/"
assert datetime.strptime(resp.source_meta_.version, "%Y%m%d") # noqa: E501
assert resp.source_meta_.data_license == "CC0"
assert (
resp.source_meta_.data_license_url == "https://www.genenames.org/about/license/"
)
assert datetime.strptime(resp.source_meta_.version, "%Y%m%d")
assert resp.source_meta_.data_url == {
"complete_set_archive": "ftp://ftp.ebi.ac.uk/pub/databases/genenames/hgnc/json/hgnc_complete_set.json"
}
Expand Down