feat!: use vrs 2.0-alpha core gene model in /normalize #252

korikuzma · 2023-09-13T00:34:02Z

Close #250 . Going to wait until I confirm everything works in metakb. But would still like your review @jsstevenson now

Notes:

bump ga4gh.vrs version to include core models
Removes custom Gene Descriptor/Extension/Gene Value Object pydantic classes and uses ga4gh.core models
Remove references to VRSATILE/VODs

jsstevenson

👍

korikuzma added 3 commits September 12, 2023 20:13

feat!: use core_models.Gene in /normalize

d2a3dc0

rm deleted class

9888eb6

forgot ccds_id

1a32958

korikuzma added enhancement New feature or request priority:high High priority labels Sep 13, 2023

korikuzma requested a review from jsstevenson September 13, 2023 00:34

korikuzma self-assigned this Sep 13, 2023

korikuzma force-pushed the issue-250 branch from 2bbc150 to 04b6dee Compare September 13, 2023 16:56

update handling ids

7875d93

korikuzma force-pushed the issue-250 branch from 04b6dee to 7875d93 Compare September 13, 2023 17:04

jsstevenson previously approved these changes Sep 14, 2023

View reviewed changes

korikuzma added 3 commits September 26, 2023 18:44

build: update ga4gh.vrs version

2931dd2

Merge branch 'staging' into issue-250

7bfedbf

fix test fixtures

85742f9

korikuzma dismissed jsstevenson’s stale review via 85742f9 September 27, 2023 01:42

Update docs

085cd7f

korikuzma added priority:medium Medium priority and removed priority:high High priority labels Sep 27, 2023

korikuzma marked this pull request as ready for review September 27, 2023 01:47

korikuzma requested a review from jsstevenson September 27, 2023 01:47

jsstevenson approved these changes Sep 27, 2023

View reviewed changes

korikuzma merged commit d3c10ad into staging Sep 27, 2023

korikuzma deleted the issue-250 branch September 27, 2023 13:34

Provide feedback