Skip to content

Commit

Permalink
feat: update HGNC license (#263)
Browse files Browse the repository at this point in the history
  • Loading branch information
jsstevenson committed Sep 29, 2023
1 parent e0c6519 commit 512d4ef
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
4 changes: 2 additions & 2 deletions gene/etl/hgnc.py
Original file line number Diff line number Diff line change
Expand Up @@ -341,8 +341,8 @@ def _add_meta(self) -> None:
"Source metadata unavailable -- was data properly acquired before attempting to load DB?"
)
metadata = SourceMeta(
data_license="custom",
data_license_url="https://www.genenames.org/about/",
data_license="CC0",
data_license_url="https://www.genenames.org/about/license/",
version=self._version,
data_url={"complete_set_archive": self._data_url},
rdp_url=None,
Expand Down
8 changes: 5 additions & 3 deletions tests/unit/test_hgnc_source.py
Original file line number Diff line number Diff line change
Expand Up @@ -837,9 +837,11 @@ def test_no_match(hgnc):
def test_meta_info(hgnc):
"""Test that the meta field is correct."""
resp = hgnc.search("HGNC:37133")
assert resp.source_meta_.data_license == "custom"
assert resp.source_meta_.data_license_url == "https://www.genenames.org/about/"
assert datetime.strptime(resp.source_meta_.version, "%Y%m%d") # noqa: E501
assert resp.source_meta_.data_license == "CC0"
assert (
resp.source_meta_.data_license_url == "https://www.genenames.org/about/license/"
)
assert datetime.strptime(resp.source_meta_.version, "%Y%m%d")
assert resp.source_meta_.data_url == {
"complete_set_archive": "ftp://ftp.ebi.ac.uk/pub/databases/genenames/hgnc/json/hgnc_complete_set.json"
}
Expand Down

0 comments on commit 512d4ef

Please sign in to comment.