Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add condition to flush based on time #4

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Add condition to flush based on time #4

merged 2 commits into from
Aug 30, 2024

Commits on Aug 26, 2024

  1. Add condition to flush based on time 

    Currently the Atlas high performance mode is enabled for all apps. This
mode enables batching of metrics to reduce the number of events sent to
spectatord.

This high performance mode has a negative impact on really low RPS apps,
because they can end up emitting IPC metrics every 2-4 minutes rather
than every minute.

This commit updates the buffering logic to ensure we emit metrics if
some configurable amount of time has passed (flush_interval).
    @fvallenilla
    fvallenilla committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    c649f23 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. PR feedback

    @fvallenilla
    fvallenilla committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    7b6255b View commit details
    Browse the repository at this point in the history