Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch up to spectator-cpp #3

Merged
merged 7 commits into from
Aug 8, 2024
Merged

Commits on Aug 4, 2024

  1. Configuration menu
    Copy the full SHA
    f2805c5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    50bce41 View commit details
    Browse the repository at this point in the history
  3. add monotonic counter uint meter type (Netflix#105)

    This change is a companion to the fix for monotonic counter implementations in
    spectatord.
    
    Netflix-Skunkworks/spectatord#90
    
    The original monotonic counter (`C`) was always intended to be used for the
    case where a monotonic data source needs to be transformed into base units
    for recording data. For example, transforming nanoseconds into seconds. This
    requires division, which results in floats.
    
    There is a valid use case for handling uints in monotonic counters, if the
    data source is already in a base unit, such as bytes. Thus, a new meter type
    `U` is added to spectatord which supports this use case.
    copperlight authored and fvallenilla committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    701a9f7 View commit details
    Browse the repository at this point in the history
  4. fix MonotonicCounterUint send bug (Netflix#107)

    It was using the existing `send` method, which formatted the value as a float,
    when it needs to be formatted as a uint.
    copperlight authored and fvallenilla committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    645095e View commit details
    Browse the repository at this point in the history
  5. replace invalid characters in ids (Netflix#106)

    It is easy enough to break the spectatord line protocol, if any of the control
    characters (`:,=`) are inserted in unexpected places. Since metric names and
    tags are often programmatically generated, we want to only construct id strings
    which are valid.
    copperlight authored and fvallenilla committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    c24bba1 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Check in generated file

    This file is generated by tools/gen_valid_chars.
    fvallenilla committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    cf40710 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Add build/test container

    fvallenilla committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    d99a5a4 View commit details
    Browse the repository at this point in the history