forked from Netflix/spectator-cpp
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch up to spectator-cpp #3
Merged
Merged
Commits on Aug 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f2805c5 - Browse repository at this point
Copy the full SHA f2805c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 50bce41 - Browse repository at this point
Copy the full SHA 50bce41View commit details -
add monotonic counter uint meter type (Netflix#105)
This change is a companion to the fix for monotonic counter implementations in spectatord. Netflix-Skunkworks/spectatord#90 The original monotonic counter (`C`) was always intended to be used for the case where a monotonic data source needs to be transformed into base units for recording data. For example, transforming nanoseconds into seconds. This requires division, which results in floats. There is a valid use case for handling uints in monotonic counters, if the data source is already in a base unit, such as bytes. Thus, a new meter type `U` is added to spectatord which supports this use case.
Configuration menu - View commit details
-
Copy full SHA for 701a9f7 - Browse repository at this point
Copy the full SHA 701a9f7View commit details -
fix MonotonicCounterUint send bug (Netflix#107)
It was using the existing `send` method, which formatted the value as a float, when it needs to be formatted as a uint.
Configuration menu - View commit details
-
Copy full SHA for 645095e - Browse repository at this point
Copy the full SHA 645095eView commit details -
replace invalid characters in ids (Netflix#106)
It is easy enough to break the spectatord line protocol, if any of the control characters (`:,=`) are inserted in unexpected places. Since metric names and tags are often programmatically generated, we want to only construct id strings which are valid.
Configuration menu - View commit details
-
Copy full SHA for c24bba1 - Browse repository at this point
Copy the full SHA c24bba1View commit details
Commits on Aug 5, 2024
-
This file is generated by tools/gen_valid_chars.
Configuration menu - View commit details
-
Copy full SHA for cf40710 - Browse repository at this point
Copy the full SHA cf40710View commit details
Commits on Aug 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d99a5a4 - Browse repository at this point
Copy the full SHA d99a5a4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.