Run eslint on the scripts directory

.github/workflows/checks.yml

@@ -1,6 +1,3 @@
-# This workflow will do a clean install of node dependencies, cache/restore them, build the source code and run tests across different versions of node
-# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions
-
 name: RxPlayer Tests
 
 on:
@@ -29,7 +26,7 @@ jobs:
         with:
           toolchain: stable
 
-      - run: npm install
+      - run: npm ci
       - run: rustup target add wasm32-unknown-unknown
       - run: npm run fmt:prettier:check
       - run: npm run fmt:rust:check
@@ -49,7 +46,7 @@ jobs:
         with:
           node-version: ${{ matrix.node-version }}
           cache: "npm"
-      - run: npm install
+      - run: npm ci
       - run: npm run check
 
   unit_tests:
@@ -67,7 +64,7 @@ jobs:
         with:
           node-version: ${{ matrix.node-version }}
           cache: "npm"
-      - run: npm install
+      - run: npm ci
       - run: npm run test:unit
 
   integration_linux:
@@ -89,7 +86,7 @@ jobs:
       - run:
           sudo add-apt-repository multiverse && sudo apt update && sudo apt install -y
           ubuntu-restricted-extras
-      - run: npm install
+      - run: npm ci
       - run: npm run build
       - run: npm run test:integration
 
@@ -112,5 +109,5 @@ jobs:
       - run:
           sudo add-apt-repository multiverse && sudo apt update && sudo apt install -y
           ubuntu-restricted-extras
-      - run: npm install
+      - run: npm ci
       - run: npm run test:memory

.github/workflows/demo_check.yml

@@ -0,0 +1,26 @@
+name: RxPlayer Demo Checks
+
+on:
+  pull_request:
+    types: [opened, synchronize, reopened]
+    paths:
+      - demo/**
+
+jobs:
+  scripts_lint:
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        node-version: [20.x]
+        # See supported Node.js release schedule at https://nodejs.org/en/about/releases/
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Use Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v2
+        with:
+          node-version: ${{ matrix.node-version }}
+          cache: "npm"
+      - run: npm ci
+      - run: npm run check:demo

.github/workflows/perfs.yml

@@ -18,7 +18,7 @@ jobs:
       - run:
           sudo add-apt-repository multiverse && sudo apt update && sudo apt install -y
           ubuntu-restricted-extras
-      - run: npm install
+      - run: npm ci
       - run: export DISPLAY=:99
       - run: sudo Xvfb -ac :99 -screen 0 1280x1024x24 > /dev/null 2>&1 & # optional
       - run: node tests/performance/run.mjs

.github/workflows/script_check.yml

@@ -0,0 +1,26 @@
+name: RxPlayer Script Checks
+
+on:
+  pull_request:
+    types: [opened, synchronize, reopened]
+    paths:
+      - scripts/**
+
+jobs:
+  scripts_lint:
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        node-version: [20.x]
+        # See supported Node.js release schedule at https://nodejs.org/en/about/releases/
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Use Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v2
+        with:
+          node-version: ${{ matrix.node-version }}
+          cache: "npm"
+      - run: npm ci
+      - run: npm run lint:scripts

.github/workflows/tests_check.yml

@@ -0,0 +1,26 @@
+name: RxPlayer Tests Checks
+
+on:
+  pull_request:
+    types: [opened, synchronize, reopened]
+    paths:
+      - tests/**
+
+jobs:
+  tests_lint:
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        node-version: [20.x]
+        # See supported Node.js release schedule at https://nodejs.org/en/about/releases/
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Use Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v2
+        with:
+          node-version: ${{ matrix.node-version }}
+          cache: "npm"
+      - run: npm ci
+      - run: npm run lint:tests

package.json

@@ -151,7 +151,7 @@
     "bundle:watch": "./scripts/run_bundler.mjs src/index.ts --production-mode -o dist/rx-player.js --watch",
     "certificate": "./scripts/generate_certificate",
     "check": "npm run check:types && npm run lint && npm run check:types:unit_tests",
-    "check:all": "npm run check:types && npm run lint && npm run lint:demo && npm run lint:tests && npm run test:unit && npm run test:integration && npm run test:memory && node -r esm ./scripts/check_nodejs_import_compatibility.js",
+    "check:all": "npm run check:types && npm run lint && npm run lint:demo && npm run lint:tests && npm run lint:scripts && npm run test:unit && npm run test:integration && npm run test:memory && node -r esm ./scripts/check_nodejs_import_compatibility.js",
     "check:demo": "npm run check:demo:types && npm run lint:demo",
     "check:demo:types": "tsc --noEmit --project demo/",
     "clean:build": "scripts/remove_dir.mjs dist",
@@ -169,6 +169,7 @@
     "fmt:rust:check": "cd ./src/parsers/manifest/dash/wasm-parser && cargo fmt --check",
     "lint": "eslint src -c .eslintrc.js",
     "lint:demo": "eslint -c demo/.eslintrc.js demo/scripts",
+    "lint:scripts": "eslint -c scripts/.eslintrc.js --ext .js --ext .mjs --ext .cjs scripts",
     "lint:tests": "eslint tests/**/*.js --ignore-pattern '/tests/performance/bundle*'",
     "list": "node scripts/list-npm-scripts.mjs",
     "prepublishOnly": "npm run build:all",

scripts/.eslintrc.js

@@ -0,0 +1,53 @@
+module.exports = {
+  root: true,
+  parserOptions: {
+    ecmaVersion: 2020,
+    sourceType: "module",
+  },
+  env: {
+    es6: true,
+    node: true,
+    commonjs: true,
+  },
+  extends: ["prettier"],
+  rules: {
+    "comma-dangle": [1, "only-multiline"],
+    "no-cond-assign": 0,
+    "no-constant-condition": 0,
+    "no-control-regex": 0,
+    "no-debugger": 2,
+    "no-dupe-args": 2,
+    "no-dupe-keys": 2,
+    "no-duplicate-case": 1,
+    "no-empty-character-class": 1,
+    "no-empty": 0,
+    "no-ex-assign": 1,
+    "no-extra-boolean-cast": 1,
+    "no-extra-parens": [1, "functions"],
+    "no-extra-semi": 2,
+    "no-func-assign": 2,
+    "no-inner-declarations": 0,
+    "no-invalid-regexp": 1,
+    "no-irregular-whitespace": 1,
+    "no-negated-in-lhs": 2,
+    "no-obj-calls": 2,
+    "no-regex-spaces": 1,
+    "no-sparse-arrays": 2,
+    "no-unreachable": 2,
+    "use-isnan": 2,
+    "valid-jsdoc": 0,
+    "valid-typeof": 2,
+    "no-unexpected-multiline": 0,
+    "no-trailing-spaces": 2,
+    "no-multiple-empty-lines": 1,
+    "accessor-pairs": [1, { setWithoutGet: true }],
+    "block-scoped-var": 1,
+    complexity: 0,
+    curly: [1, "all"],
+    "no-case-declarations": 0,
+    "no-var": 1,
+    "prefer-const": 1,
+    "linebreak-style": [1, "unix"],
+    semi: [1, "always"],
+  },
+};

scripts/run_bundler.mjs

@@ -62,16 +62,18 @@ if (import.meta.url === pathToFileURL(process.argv[1]).href) {
   }
 
   try {
-    await runBundler(normalizedPath, {
+    runBundler(normalizedPath, {
       watch: shouldWatch,
       minify: shouldMinify,
       production,
       silent,
       outfile,
+    }).catch((err) => {
+      console.error(`ERROR: ${err}\n`);
+      process.exit(1);
     });
   } catch (err) {
     console.error(`ERROR: ${err}\n`);
-    displayHelp();
     process.exit(1);
   }
 }