Commits on Oct 8, 2024

1. DASH: Remove "native" JS parser …

   From the v4.1.0, we had 3 MPD parsers:
   
     - The "native" one, relying on the web's DOMParser API.
   
       This is historically the first one we used and still the one we rely
       by default on main thread.
   
     - The "WebAssembly" one, added in 2021.
   
       This one was initially written when we had to manage multi-megabytes
       MPD. Those took forever to parse on low-end devices but worse even
       on a PC, parsing it often (e.g. for a live content) could lead to a
       crash after several hours due to GC pressure.
   
       The idea was to parse the MPD in another thread (the initial
       MULTI_THREAD attempts date back from here :p) and to rely on
       WebAssembly to better control memory usage and performance (also the
       "native" one wasn't usable anyway on a WebWorker due to browser
       limitations).
   
       It turned out that the WebAssembly version was so light (note: we
       also rely on XML StAX parsing instead of DOM parsing which may have
       helped for that part) and fast that we didn't yet need the
       complexity of bringing another thread here.
   
     - The "fast js" one, added at the last `v4.1.0` release.
   
       This one follows attempts to make the `MULTI_THREAD` feature usable
       on non-WebAssembly devices. We noticed that other developers had
       recently made attempts for fast JS parsing without even needing the
       use of the DOMParser. They reported even faster performance due to
       much fewer XML integrity checks (which is OK for us, as MPD parsing
       performance is one of the most important aspect for us).
   
   This commit proposes that we remove the "native" one to just replace it
   by the "fast js" one.
   
   The "fast js" one has already been used in production for more than 6
   months without issue, is equal-to-faster than the native one and it
   would lead to much less code.

   

   peaBerberian committed Oct 8, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 046a368
   • Browse repository at this point

   Copy the full SHA

   046a368 View commit details

   Browse the repository at this point in the history