Demo/v4: Add possibility to see the debug element in the demo page #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `createDebugElement` method allows to generate an RxPlayer-made debug element. It is used most often as a stats-for-nerds-like kind of things to quickly inspect, debug and report issues by displaying some interesting playback stats without having to dive into debug logs to obtain them. We didn't yet add a possibility to show them in the demo, so this commit quickly does that. It does it in the laziest way possible, by just adding a "Display debug element" checkbox in the chart area of the demo, which will display debug information on top of the media element when enabled and playing content. It may have more its place in the controls (which is what e.g. YouTube or Twitch choose to do in their production page for their debug divs, and Canal+' main products most often set it in a contextual menu), I don't even know if it does or not, but I was too lazy to do this just for our demo page. Putting it in chart was much simpler because no controls with checkbox exist yet, whereas charts only have checkboxes. So I just chose the easiest way!
peaBerberian
force-pushed
the
demo/debug-element
branch
from
5fa0325
to
1581948
Compare
|
Nice! |
Florent-Bouisset
approved these changes
Nov 21, 2023
peaBerberian
added a commit
that referenced
this pull request
Nov 23, 2023
Demo/v4: Add possibility to see the debug element in the demo page
peaBerberian
added a commit
that referenced
this pull request
Dec 4, 2023
Demo/v4: Add possibility to see the debug element in the demo page
peaBerberian
added a commit
that referenced
this pull request
Dec 5, 2023
Demo/v4: Add possibility to see the debug element in the demo page
peaBerberian
added a commit
that referenced
this pull request
Dec 5, 2023
Demo/v4: Add possibility to see the debug element in the demo page
peaBerberian
added a commit
that referenced
this pull request
Dec 7, 2023
Demo/v4: Add possibility to see the debug element in the demo page
peaBerberian
added a commit
that referenced
this pull request
Dec 19, 2023
Demo/v4: Add possibility to see the debug element in the demo page
peaBerberian
added a commit
that referenced
this pull request
Dec 20, 2023
Demo/v4: Add possibility to see the debug element in the demo page
peaBerberian
added a commit
that referenced
this pull request
Dec 22, 2023
Demo/v4: Add possibility to see the debug element in the demo page
peaBerberian
added a commit
that referenced
this pull request
Jan 3, 2024
Demo/v4: Add possibility to see the debug element in the demo page
peaBerberian
added a commit
that referenced
this pull request
Jan 3, 2024
Demo/v4: Add possibility to see the debug element in the demo page
peaBerberian
added a commit
that referenced
this pull request
Jan 11, 2024
Demo/v4: Add possibility to see the debug element in the demo page
peaBerberian
added a commit
that referenced
this pull request
Jan 11, 2024
Demo/v4: Add possibility to see the debug element in the demo page
peaBerberian
added a commit
that referenced
this pull request
Jan 15, 2024
Demo/v4: Add possibility to see the debug element in the demo page
peaBerberian
added a commit
that referenced
this pull request
Jan 23, 2024
Demo/v4: Add possibility to see the debug element in the demo page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
createDebugElementmethod allows to generate an RxPlayer-made debug element.It is used most often as a stats-for-nerds-like kind of things to quickly inspect, debug and report issues by displaying some interesting playback stats without having to dive into debug logs to obtain them.
We didn't yet had a possibility to show them in the demo, so this commit quickly does that. It does it in the laziest way possible, by just adding a "Display debug element" checkbox in the chart area of the demo, which will display debug information on top of the media element when enabled and playing content.
Debug element shown on top of the video element, with the corresponding checkbox enabled (at the bottom of the screenshot)
It may have more its place in the controls (which is what e.g. YouTube or Twitch choose to do in their production page for their debug divs, and Canal+' main products most often set it in a contextual menu), I don't even know if it does or not, but I was too lazy to do this just for our demo page.
Putting it in charts was much simpler because no controls with checkbox exist yet, whereas charts only have checkboxes. So I just chose the easiest way!