Transition all rx-player scripts to es6 style imports #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peaBerberian
force-pushed
the
misc/scripts-to-es6
branch
from
78ed67c
to
4d93406
Compare
peaBerberian
force-pushed
the
misc/conditional-export
branch
from
09eb4c8
to
a40e543
Compare
I realized that in #1309, I broke the demo bundling script and translated only some of our node.js scripts so they have es6-style imports instead of commonjs ones. I fixed the issue and completely transitioned (with two exceptions for now: eslint and jest configs, but we also could transition them I guess) to es6-style imports in our scripts to facilitate development (no need to switch the import style depending on if the JS runs server-side or client-side).
peaBerberian
force-pushed
the
misc/scripts-to-es6
branch
from
4d93406
to
e099bc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that in #1309, I broke the demo bundling script and translated only some of our node.js scripts so they have es6-style imports instead of commonjs ones.
I fixed the issue and completely transitioned (with two exceptions for now:
eslint and jest configs, but we also could transition them I guess) to es6-style imports in our scripts to facilitate development (no need to switch the import style depending on if the JS runs server-side or client-side).
I also removed webpack's bundle analyzer as that dependency was never really used for now and wasn't used in a pertinent way. It can be useful but we would have to properly integrate it in that case. For now, it's just an unneeded supplementary dev dependency.