Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proposal] scte214 - use supplemental codec instead of base codec if it's supported #1307

Merged
merged 20 commits into from
Nov 13, 2023
Merged

[Proposal] scte214 - use supplemental codec instead of base codec if it's supported #1307

merged 20 commits into from
Nov 13, 2023

Commits on Oct 27, 2023

  1. parse supplemental codec

    @Florent-Bouisset
    Florent-Bouisset committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    7d1ecef View commit details
    Browse the repository at this point in the history

  2. add a property isSupplementalCoded supported and update getMimeType

    @Florent-Bouisset
    Florent-Bouisset committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    85b5941 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. add documentation for isSupplementalCodecSupported property

    @Florent-Bouisset
    Florent-Bouisset committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    09e1d03 View commit details
    Browse the repository at this point in the history

  2. parse supplementalCodec in the adaptation set

    @Florent-Bouisset
    Florent-Bouisset committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    6c67e53 View commit details
    Browse the repository at this point in the history

  3. return the codec that will be played if both supplemental codec is su… 

    …pported
    @Florent-Bouisset
    Florent-Bouisset committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    e7d22a6 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. parse multiple supplemental codec separated by white space

    @Florent-Bouisset
    Florent-Bouisset committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    c5cb8c7 View commit details
    Browse the repository at this point in the history

  2. avoid unecessary call to iseCodecSupported if supplementalCodec is true

    @Florent-Bouisset
    Florent-Bouisset committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    c57acb9 View commit details
    Browse the repository at this point in the history

  3. remove test file that shouldn't have been add

    @Florent-Bouisset
    Florent-Bouisset committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    d14148b View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. remplace == with isNullOrUndefined function

    @Florent-Bouisset
    Florent-Bouisset committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    2d56d1a View commit details
    Browse the repository at this point in the history

  2. update regex to match more unexpected whitespace

    @Florent-Bouisset
    Florent-Bouisset committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    3d7d1da View commit details
    Browse the repository at this point in the history

  3. code review

    @Florent-Bouisset
    Florent-Bouisset committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    49d1a7d View commit details
    Browse the repository at this point in the history

  4. update rust WASM parser to parse supplementalCodecs

    @Florent-Bouisset
    Florent-Bouisset committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    385b533 View commit details
    Browse the repository at this point in the history

  5. doc: update rfc number that obsoletes rfc4281

    @Florent-Bouisset
    Florent-Bouisset committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    7bdef9d View commit details
    Browse the repository at this point in the history

  6. move codec converting logic in "common" to convert from any parser

    @Florent-Bouisset
    Florent-Bouisset committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    9010407 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. code review

    @Florent-Bouisset
    Florent-Bouisset committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    a02d3df View commit details
    Browse the repository at this point in the history

  2. set the codec to supplementalCodec if supported and remove supplement… 

    …alCodec in the representation
    @Florent-Bouisset
    Florent-Bouisset committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    0a694d7 View commit details
    Browse the repository at this point in the history

  3. handle case for subtitle

    @Florent-Bouisset
    Florent-Bouisset committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    be795bc View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. move code to another folder

    @Florent-Bouisset
    Florent-Bouisset committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    b16c914 View commit details
    Browse the repository at this point in the history

  2. reset unchanged file

    @Florent-Bouisset
    Florent-Bouisset committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    435033d View commit details
    Browse the repository at this point in the history

  3. remove staged file

    @Florent-Bouisset
    Florent-Bouisset committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    99d3a3f View commit details
    Browse the repository at this point in the history