wait-for-it / handle several databases if needed (primary/secondary/etc)

[nesies]

Fixes camunda/camunda-bpm-platform#3555

If you specify several database in your JDBC_URL, you might want to start if at latest on of them is responding.

camunda/camunda-bpm-platform#3555

[tasso94]

Hi @nesies,

Thank you for your pull request.

My colleague @yanavasileva will look into it after the summer break.

Stay tuned!

Best,
Tassilo

[yanavasileva]

Overall the implementation looks good to me. I added suggestions for the wording in the run script, please consider them for all of the three scripts.
Meantime, I would ask for a second reviewer in case I overlooked something.

[yanavasileva]

@tasso94, could you please have a look at this feature request contribution in case I overlooked some aspect.

[nesies]

thanks, i made the changes

[tasso94]

@yanavasileva, I had a brief look, and here is my input:

• Can we consolidate the code into a single file so that we don't need to change it at multiple places in the future? When fixing something, we might miss changing it everywhere in the future, which is not as maintainable as it could be.
• I haven't checked it in detail, but we must ensure this doesn't change how it previously worked (backwards compatibility). Can you double-check that?

[yanavasileva]

@nesies, thank you for applying the review hints so far.
Could you also consolidate the code into a single file as suggested by tasso94 above?

[yanavasileva]

Hi @nesies,

The current implementation is failing and I think a few components are missing:

• ensure the correct name is passed for the "common-lib"
• ensure the file is present when a docker image is created
• test the docker image with the following scenarios:
  • the WAIT_FOR argument not passed
  • WAIT_FOR argument given with one db connection
  • WAIT_FOR argument given with two or more db connections

[yanavasileva]

👍 @nesies, looks good. Thank you for implementing our feedback.

Before I merge the request, could you please also adjust the readme with the new option specifying the syntax when the user passes multiple host:port to wait for.

[yanavasileva]

@nesies, I merged the code with (cf15703) after adjusting the readme. The feature will be available with Camunda 7.21 and next 7.21.0-alpha3. Once again, thank you for the contribution.