chore(email-tests): 3986 email connector e2e tests are flaky #4051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
connectors/email/src/test/java/io/camunda/connector/email/integration/InboundEmailTest.java
Dismissed
Show dismissed
Hide dismissed
mathias-vandaele
force-pushed
the
3986-email-connector-e2e-tests-are-flaky
branch
4 times, most recently
from
751155f to
ef909d9
Compare
mathias-vandaele
force-pushed
the
3986-email-connector-e2e-tests-are-flaky
branch
from
ef909d9 to
09ba824
Compare
johnBgood
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
Great but I would rename the package. These are not integration tests as we don't have any "real" mail server there. They look like regular UTs to me.
If you want integration tests, I recommend using docker-mailserver along with TestContainers. That would be great, but it's up to you 🇵🇭
mathias-vandaele
deleted the
3986-email-connector-e2e-tests-are-flaky
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All the e2e have been migrated to integration tests
Related issues
closes #3986
Checklist
no milestonelabel.