Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sendgrid): attachment support #3891

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DenovVasil
Copy link
Contributor

@DenovVasil DenovVasil commented Jan 30, 2025

Description

attachments support for sendgrid connector

Related issues

image

element template pr
documentation pr

2025-01-31.13-18-51.mov

@DenovVasil DenovVasil requested a review from a team as a code owner January 30, 2025 19:48
@DenovVasil DenovVasil self-assigned this Jan 30, 2025
@DenovVasil DenovVasil added this to the 8.7.0-alpha4 milestone Jan 30, 2025
johnBgood
johnBgood previously approved these changes Jan 31, 2025
Copy link
Collaborator

@johnBgood johnBgood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DenovVasil DenovVasil force-pushed the 988-support-attachments-for-sendgrid branch 3 times, most recently from a6d9880 to 95c3b84 Compare January 31, 2025 12:37
@DenovVasil DenovVasil force-pushed the 988-support-attachments-for-sendgrid branch from 95c3b84 to 3e3e1ce Compare February 3, 2025 09:21
@DenovVasil DenovVasil force-pushed the 988-support-attachments-for-sendgrid branch 2 times, most recently from 062bd78 to 328c2c4 Compare February 3, 2025 13:12
Copy link
Contributor

@sbuettner sbuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@DenovVasil DenovVasil force-pushed the 988-support-attachments-for-sendgrid branch from 328c2c4 to 6335e35 Compare February 3, 2025 18:56
@DenovVasil DenovVasil added the qa:required Will trigger the QA workflow label Feb 5, 2025
@johnBgood
Copy link
Collaborator

QA information

Test Environment

  • Test required in (you can check both):
    • SaaS
    • SM
  • Create a new test for this feature in our Pre Release Tests for @Szik to be able to test

Test Scope

Please describe the test scope, happy path, edge cases that come to your mind, and whatever you think might relevant to test

Test Data

Please provide the test data, if needed (files, URLs, code snippets, FEEL expressions)

Copy link
Contributor

github-actions bot commented Feb 5, 2025

🚀 Deployment Results 🚀

Please find below the results of the latest deployments.

connectors-988-support-att-c8sm

  • Status:
  • URL: 🌐 Link
  • ArgoCD: 🔗 Link
  • Deployment Jobs: 📋 Link

🔧 Troubleshooting 🔧

The 🔗 ArgoCD link can be used to check the state and configuration of all the services deployed as part of the preview environments and get logs.

In case of error, please check 📋 Deployment Jobs and 🔗 ArgoCD to debug, and check our (yet to come) troubleshooting page

@sbuettner sbuettner modified the milestones: 8.7.0-alpha4, 8.8.0-alpha2 Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-preview qa:required Will trigger the QA workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants