Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1/?] Fix anchor links - expressions #3732

Merged
merged 4 commits into from
Apr 29, 2024
Merged

[1/?] Fix anchor links - expressions #3732

merged 4 commits into from
Apr 29, 2024

Conversation

akeller
Copy link
Member

@akeller akeller commented Apr 26, 2024

Description

Related to #3442

When should this change go live?

  • This change is not yet live and should not be merged until {ADD_DATE} (apply hold label or convert to draft PR)?
  • There is no urgency with this change.
  • This change or page is part of a marketing blog, conference talk, or something else on a schedule.
  • This functionality is already available but undocumented.
  • This is a bug fix or security concern.

PR Checklist

  • I have added changes to the relevant /versioned_docs directory, or they are not for an already released version.
  • I have added changes to the main /docs directory (aka /next/), or they are not for future versions.
  • My changes require an Engineering review, and I've assigned an engineering manager or tech lead as a reviewer, or my changes do not require an Engineering review.
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer, or my changes do not require a technical writer review.

@akeller akeller added the component:docs Documentation improvements, including new or updated content label Apr 26, 2024
@akeller akeller requested a review from christinaausley April 26, 2024 20:54
@akeller akeller self-assigned this Apr 26, 2024
Copy link
Contributor

github-actions bot commented Apr 26, 2024

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in versioned_docs/version-8.5/. You might want to duplicate these changes in docs/.

  • versioned_docs/version-8.5/components/concepts/outbound-connectors-job-workers.md
  • versioned_docs/version-8.5/self-managed/connectors-deployment/install-and-start.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@akeller akeller added the hold This issue is parked, do not merge. label Apr 26, 2024
@akeller akeller removed the hold This issue is parked, do not merge. label Apr 26, 2024
Copy link
Contributor

@christinaausley christinaausley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@akeller akeller merged commit 4c22a55 into main Apr 29, 2024
6 of 7 checks passed
@akeller akeller deleted the anchor-link-expression branch April 29, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants