Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dmn): bump feel scala version to 1.18.1 #4783

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mboskamp
Copy link
Member

Related to #4530

@mboskamp mboskamp self-assigned this Nov 11, 2024
@mboskamp mboskamp added bot:backport:7.21 Backports PR to maintenance branch 7.21. bot:backport:7.22 labels Nov 11, 2024
@@ -28,7 +28,7 @@
<version.mybatis>3.5.15</version.mybatis>
<version.joda-time>2.12.5</version.joda-time>
<version.uuid-generator>4.3.0</version.uuid-generator>
<version.feel-scala>1.17.5</version.feel-scala>
<version.feel-scala>1.18.1</version.feel-scala>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Since I see the backport labels here, should we really update all maintenance versions to a new FEEL Engine minor version? Instead, I would propose updating master to the newest minor version and maintenance versions to respective patch levels.

Copy link
Member Author

@mboskamp mboskamp Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. I thought about not bumping to the next minor. However, the release notes don't look problematic, so I wanted to try it out on this PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't dare introducing regressions via a patch release, given this list:
https://github.com/camunda/feel-scala/releases/tag/1.18.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the backport labels. Will move to 1.17.9 for the backports.

@mboskamp mboskamp removed bot:backport:7.21 Backports PR to maintenance branch 7.21. bot:backport:7.22 labels Nov 12, 2024
@mboskamp mboskamp marked this pull request as ready for review November 14, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants