Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4620 add historic process instance query to execute modification async #4624

Merged
merged 10 commits into from
Sep 20, 2024
Merged

4620 add historic process instance query to execute modification async #4624

merged 10 commits into from
Sep 20, 2024

Conversation

venetrius
Copy link
Member

related to: #4620

@venetrius venetrius self-assigned this Sep 17, 2024
@venetrius venetrius force-pushed the 4620-add-historicProcessInstanceQuery-to-executeModificationAsync branch from a7621b8 to 8c59deb Compare September 17, 2024 13:41
@venetrius venetrius mentioned this pull request Sep 17, 2024
Closed
@venetrius venetrius force-pushed the 4620-add-historicProcessInstanceQuery-to-executeModificationAsync branch from 8c59deb to 839b1f1 Compare September 17, 2024 15:50
@yanavasileva yanavasileva added ci:default-build Runs the builds that have no explicit trigger (e.g. different history levels). ci:rest-api Runs extra builds for the REST API (currently only WLS compatibility builds). ci:skipTests Skips tests execution in Assembly and Distro-ee stages. labels Sep 18, 2024
yanavasileva
yanavasileva reviewed Sep 18, 2024
View reviewed changes
Copy link
Member

@yanavasileva yanavasileva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't completed the review, just share first glance problems.

...ne/src/test/java/org/camunda/bpm/engine/test/api/runtime/ModificationExecutionAsyncTest.java Show resolved Hide resolved
...ne/src/test/java/org/camunda/bpm/engine/test/api/runtime/ModificationExecutionAsyncTest.java Show resolved Hide resolved
engine-rest/engine-rest/src/main/java/org/camunda/bpm/engine/rest/dto/ModificationDto.java Show resolved Hide resolved
...e-rest-openapi/src/main/templates/models/org/camunda/bpm/engine/rest/dto/ModificationDto.ftl Show resolved Hide resolved
@yanavasileva yanavasileva removed the ci:skipTests Skips tests execution in Assembly and Distro-ee stages. label Sep 19, 2024
yanavasileva
yanavasileva requested changes Sep 19, 2024
View reviewed changes
Copy link
Member

@yanavasileva yanavasileva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Impl looks good, some tests need improvement + hint in the docs.

engine/src/main/java/org/camunda/bpm/engine/runtime/ModificationBuilder.java Show resolved Hide resolved
...ne/src/test/java/org/camunda/bpm/engine/test/api/runtime/ModificationExecutionAsyncTest.java Outdated Show resolved Hide resolved
...ne/src/test/java/org/camunda/bpm/engine/test/api/runtime/ModificationExecutionAsyncTest.java Outdated Show resolved Hide resolved
...ne/src/test/java/org/camunda/bpm/engine/test/api/runtime/ModificationExecutionAsyncTest.java Outdated Show resolved Hide resolved
...ne/src/test/java/org/camunda/bpm/engine/test/api/runtime/ModificationExecutionAsyncTest.java Outdated Show resolved Hide resolved
...ne/src/test/java/org/camunda/bpm/engine/test/api/runtime/ModificationExecutionAsyncTest.java Show resolved Hide resolved
...e-rest/src/test/java/org/camunda/bpm/engine/rest/ModificationRestServiceInteractionTest.java Show resolved Hide resolved
engine/src/test/java/org/camunda/bpm/engine/test/api/runtime/ModificationExecutionSyncTest.java Show resolved Hide resolved
@yanavasileva yanavasileva mentioned this pull request Sep 19, 2024
Merged
yanavasileva
yanavasileva approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@yanavasileva yanavasileva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good. Thank you for considering by feedback.

...e-rest-openapi/src/main/templates/models/org/camunda/bpm/engine/rest/dto/ModificationDto.ftl Outdated Show resolved Hide resolved
...ne/src/test/java/org/camunda/bpm/engine/test/api/runtime/ModificationExecutionAsyncTest.java Outdated
int processInstanceCount = 15;
DeploymentWithDefinitions deployment = testRule.deploy(instance);
ProcessDefinition processDefinition = deployment.getDeployedProcessDefinitions().get(0);
List<String> processInstanceIds = helper.startInstances("process1", 15);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃 Not used.

Suggested change
List<String> processInstanceIds = helper.startInstances("process1", 15);

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed List<String> processInstanceIds =.
helper.startInstances("process1", 15); is required for the test

@yanavasileva
Copy link
Member

Please wait for green CI before merge.

@venetrius venetrius merged commit 1b9de30 into master Sep 20, 2024
2 checks passed
@venetrius venetrius deleted the 4620-add-historicProcessInstanceQuery-to-executeModificationAsync branch September 20, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanavasileva yanavasileva yanavasileva approved these changes

Assignees

@venetrius venetrius

Labels
ci:default-build Runs the builds that have no explicit trigger (e.g. different history levels). ci:rest-api Runs extra builds for the REST API (currently only WLS compatibility builds).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@venetrius @yanavasileva