fix(client): load local file variable #4594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related to: #4523
This was referenced Sep 11, 2024
|
Based on the code base we only test basic functionalities for External Client so I have not added / updated any tests. |
mboskamp
reviewed
Sep 16, 2024
| @@ -84,4 +85,14 @@ public String toString() { | |||
| return "DeferredFileValueImpl [mimeType=" + mimeType + ", filename=" + filename + ", type=" + type + ", isTransient=" + isTransient + ", isLoaded=" + isLoaded + "]"; | |||
| } | |||
|
|
|||
| @Override | |||
There was a problem hiding this comment.
🔧 Can we move the new getter and setter above the toString() method? This will be more consistent.
❓ Do you think it makes sense to include processInstanceId and executionId in the toString() result?
There was a problem hiding this comment.
Good points, thanks!
- Moved the new getter and setter above the
toString()method. - I think it can helpful when users use the
toString()for debugging. Updated thetoString()to includeprocessInstanceIdandexecutionId
Comment on lines
42
to
45
| void setExecutionId(String executionId); | ||
|
|
||
| String getExecutionId(); | ||
|
|
There was a problem hiding this comment.
❌ We should add Javadoc for interface methods.
mboskamp
approved these changes
Sep 16, 2024
venetrius
deleted the
4523-exJTC-fix-unable-to-load-value-of-local-file-variable
branch
tasso94
reviewed
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to: #4523