Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(engine/engine-rest): like-queries for candidate groups #4543

Merged
merged 1 commit into from
Sep 19, 2024
Merged

feat(engine/engine-rest): like-queries for candidate groups #4543

merged 1 commit into from
Sep 19, 2024

Conversation

jordy-cantaert-vaph
Copy link
Contributor

Related to #4540

@CLAassistant
Copy link

CLAassistant commented Aug 20, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jordy-cantaert-vaph jordy-cantaert-vaph changed the title feat(engine-rest): like-queries for candidate groups feat(engine/engine-rest): like-queries for candidate groups Aug 20, 2024
@jordy-cantaert-vaph jordy-cantaert-vaph mentioned this pull request Aug 20, 2024
Closed
@danielkelemen danielkelemen self-requested a review August 23, 2024 13:26
@jordy-cantaert-vaph jordy-cantaert-vaph marked this pull request as ready for review August 26, 2024 12:01
@tasso94 tasso94 requested review from joaquinfelici and removed request for danielkelemen September 16, 2024 13:09
@joaquinfelici joaquinfelici mentioned this pull request Sep 17, 2024
Draft
joaquinfelici
joaquinfelici requested changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@joaquinfelici joaquinfelici left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I've reviewed the changes which seem very pertinent, and we'd like to merge this before our next release.

I've added some suggestions to consider before we can merge it. We have a code freeze at the end of this week, so I'd appreciate if you could get the PR ready before then. If you think you won't be able to work on it, let me know so I can take care of it before Friday.

I've also cloned your PR (#4621) on the Camunda repo so I can run the CI, which is still running.

Edit: ✅ CI is green.

engine/src/main/java/org/camunda/bpm/engine/impl/TaskQueryImpl.java Outdated Show resolved Hide resolved
engine/src/main/java/org/camunda/bpm/engine/impl/TaskQueryImpl.java Outdated Show resolved Hide resolved
engine/src/main/java/org/camunda/bpm/engine/impl/TaskQueryImpl.java Outdated Show resolved Hide resolved
engine/src/main/java/org/camunda/bpm/engine/task/TaskQuery.java Outdated Show resolved Hide resolved
engine/src/main/resources/org/camunda/bpm/engine/impl/mapping/entity/Task.xml Outdated Show resolved Hide resolved
engine/src/test/java/org/camunda/bpm/engine/test/api/filter/FilterTaskQueryTest.java Outdated Show resolved Hide resolved
engine/src/test/java/org/camunda/bpm/engine/test/api/task/TaskQueryTest.java Outdated Show resolved Hide resolved
@benstroobants-vaph
Copy link

Hi @joaquinfelici Thanks for your review! I'm a colleague of Jordy (he's on holiday), so I've done my best to tackle your review remarks.

@jordy-cantaert-vaph @joaquinfelici
feat(engine): like-queries for candidate groups
e741ceb 
- adds functionality to filter tasks on a candidate group using a like-statement

related to camunda#4540
@joaquinfelici
Copy link
Contributor

joaquinfelici commented Sep 19, 2024 •
edited
Loading

Hello @benstroobants-vaph ,
Thanks for tackling my suggestions, everything looks great. I tweaked a bit the tests in the comments, rebased and squashed the commits. I'll relaunch the CI and approve the PR if everything is green.

joaquinfelici
joaquinfelici approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@joaquinfelici joaquinfelici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good. CI is also green.

@joaquinfelici joaquinfelici merged commit 79b001b into camunda:master Sep 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benstroobants-vaph benstroobants-vaph benstroobants-vaph left review comments

@joaquinfelici joaquinfelici joaquinfelici approved these changes

Assignees

@jordy-cantaert-vaph jordy-cantaert-vaph

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jordy-cantaert-vaph @CLAassistant @benstroobants-vaph @joaquinfelici