Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(db): use uppercase DB property names #4542

Merged
merged 1 commit into from
Aug 23, 2024
Merged

chore(db): use uppercase DB property names #4542

merged 1 commit into from
Aug 23, 2024

Conversation

mboskamp
Copy link
Member

@mboskamp mboskamp commented Aug 19, 2024 •
edited
Loading

Related to #4525

@mboskamp mboskamp added ci:all-db Runs the builds for all databases. ci:default-build Runs the builds that have no explicit trigger (e.g. different history levels). ci:webapp-integration Runs the webapp integration builds. labels Aug 19, 2024
@mboskamp mboskamp self-assigned this Aug 19, 2024
@mboskamp mboskamp mentioned this pull request Aug 19, 2024
Closed
1 task
@mboskamp mboskamp added bot:backport:7.20 Backports PR to maintenance branch 7.20. bot:backport:7.21 Backports PR to maintenance branch 7.21. labels Aug 20, 2024
@mboskamp mboskamp marked this pull request as ready for review August 20, 2024 09:28
danielkelemen
danielkelemen reviewed Aug 21, 2024
View reviewed changes
Copy link
Member

@danielkelemen danielkelemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks pretty good, great that you've found more lower case columns!
I added a few comments and thoughts.

engine/src/test/java/org/camunda/bpm/engine/test/persistence/DatabaseNamingConsistencyTest.java Outdated Show resolved Hide resolved
engine/src/test/java/org/camunda/bpm/engine/test/persistence/DatabaseNamingConsistencyTest.java Outdated Show resolved Hide resolved
engine/src/test/java/org/camunda/bpm/engine/test/persistence/DatabaseNamingConsistencyTest.java Outdated Show resolved Hide resolved
engine/src/test/java/org/camunda/bpm/engine/test/persistence/DatabaseNamingConsistencyTest.java Outdated Show resolved Hide resolved
engine/src/test/java/org/camunda/bpm/engine/test/persistence/DatabaseNamingConsistencyTest.java Outdated Show resolved Hide resolved
danielkelemen
danielkelemen approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@danielkelemen danielkelemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Code looks good!

engine/src/test/java/org/camunda/bpm/engine/test/persistence/DatabaseNamingConsistencyTest.java Show resolved Hide resolved
@mboskamp
Copy link
Member Author

CI failures:

No more failures, and approved. I will merge it to master now and create the backports.

@mboskamp mboskamp merged commit c28764a into master Aug 23, 2024
2 of 5 checks passed
@mboskamp mboskamp deleted the 4525-SQL-collation-cs branch August 23, 2024 12:10
@ap-development-workflow
Copy link

Successfully created backport PR for 7.20:

  • camunda/camunda-bpm-platform-maintenance#1274

@ap-development-workflow
Copy link

Successfully created backport PR for 7.21:

  • camunda/camunda-bpm-platform-maintenance#1275

@mboskamp mboskamp mentioned this pull request Sep 18, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielkelemen danielkelemen danielkelemen approved these changes

Assignees

@mboskamp mboskamp

Labels
bot:backport:7.20 Backports PR to maintenance branch 7.20. bot:backport:7.21 Backports PR to maintenance branch 7.21. ci:all-db Runs the builds for all databases. ci:default-build Runs the builds that have no explicit trigger (e.g. different history levels). ci:webapp-integration Runs the webapp integration builds.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mboskamp @danielkelemen