Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(databases): add oracle 23ai #4522

Merged
merged 6 commits into from
Aug 22, 2024
Merged

chore(databases): add oracle 23ai #4522

merged 6 commits into from
Aug 22, 2024

Conversation

tasso94
Copy link
Member

@tasso94 tasso94 commented Aug 6, 2024

related to #4001

@tasso94 tasso94 added the ci:oracle Runs the builds for the Oracle database. label Aug 6, 2024
@tasso94 tasso94 self-assigned this Aug 6, 2024
@tasso94 tasso94 mentioned this pull request Aug 6, 2024
Closed
1 task
@tasso94 tasso94 added the ci:skipTests Skips tests execution in Assembly and Distro-ee stages. label Aug 7, 2024
tasso94
tasso94 commented Aug 19, 2024
View reviewed changes
Jenkinsfile Outdated Show resolved Hide resolved
yanavasileva
yanavasileva reviewed Aug 20, 2024
View reviewed changes
Copy link
Member

@yanavasileva yanavasileva left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice findings. I left some questions.

Re: old-engine and Oracle 23. I agree we should not run these tests with Oracle23. How is the best way to achieve that, not sure. 🤔

database/pom.xml Show resolved Hide resolved
...rc/test/java/org/camunda/bpm/engine/test/persistence/ConnectionPersistenceExceptionTest.java Show resolved Hide resolved
engine/src/main/java/org/camunda/bpm/engine/impl/db/sql/DbSqlSession.java Outdated Show resolved Hide resolved
.ci/config/matrices.yaml Show resolved Hide resolved
yanavasileva
yanavasileva requested changes Aug 21, 2024
View reviewed changes
Copy link
Member

@yanavasileva yanavasileva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done, please proceed with skipping old-engine for Oracle 23.
I also managed to run some tests against Oracle 23 and portainer.

database/pom.xml Show resolved Hide resolved
.ci/config/matrices.yaml Show resolved Hide resolved
...rc/test/java/org/camunda/bpm/engine/test/persistence/ConnectionPersistenceExceptionTest.java Show resolved Hide resolved
yanavasileva
yanavasileva approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@yanavasileva yanavasileva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me.

@tasso94 tasso94 added the ci:no-build Prevents any CI stage from running. label Aug 22, 2024
@tasso94 tasso94 merged commit 95ad993 into master Aug 22, 2024
1 of 2 checks passed
@tasso94 tasso94 deleted the 4001-oracle-23 branch August 22, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanavasileva yanavasileva yanavasileva approved these changes

Assignees

@tasso94 tasso94

Labels
ci:no-build Prevents any CI stage from running. ci:oracle Runs the builds for the Oracle database. ci:skipTests Skips tests execution in Assembly and Distro-ee stages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tasso94 @yanavasileva