Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(quarkus-extesion/engine): Fix Flaky Quarkus Test #3991

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

psavidis
Copy link
Contributor

@psavidis psavidis commented Dec 5, 2023

Related-to: #3940

@psavidis psavidis added the scope:quarkus Changes to the Quarkus extension. label Dec 5, 2023
@psavidis psavidis self-assigned this Dec 5, 2023
@psavidis psavidis changed the title chore(quarku-extesion/engine): Set JobExecutorActivate to False chore(quarkus-extesion/engine): Set JobExecutorActivate to False Dec 5, 2023
@psavidis psavidis mentioned this pull request Dec 6, 2023
1 task
@psavidis psavidis added ci:h2 Runs the builds for the H2 database. and removed scope:quarkus Changes to the Quarkus extension. labels Dec 6, 2023
@psavidis psavidis changed the title chore(quarkus-extesion/engine): Set JobExecutorActivate to False chore(quarkus-extesion/engine): Fix Flaky Quarkus Test Dec 6, 2023
Copy link
Member

@yanavasileva yanavasileva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Problem Description:

- ManagedJobExecutorTest#shouldExecuteJob was failing sporadically on CI due to the asynchronous execution of scheduled jobs.
  The synchronous execution of the test would query for the existence of the job. Sometimes, the job would be already completed
  by the time the Query API would make assertions on its existence and that would lead into failures.

Solution:

- Turn off the job scheduler before filing any job executions

Related-to: #3940
@psavidis psavidis merged commit 2581f58 into master Dec 12, 2023
1 of 2 checks passed
@psavidis psavidis deleted the 3940-fix-quarkus-tests branch December 12, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:h2 Runs the builds for the H2 database.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants