Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove(tests): remove telemetry configuration property #4544

Merged
merged 3 commits into from
Aug 23, 2024
Merged

remove(tests): remove telemetry configuration property #4544

merged 3 commits into from
Aug 23, 2024

Conversation

yanavasileva
Copy link
Member

@yanavasileva yanavasileva commented Aug 20, 2024 •
edited
Loading

  • exclude telemetry test in old-engine setup as telemetry feature is removed in newer versions; during rolling update users run old engine and data with new schema, so the test is not relevant for the scenario

fixes quarkus-UNIT in CE main and old-engine in CE daily/sidetrack

#4483

@yanavasileva yanavasileva added the ci:default-build Runs the builds that have no explicit trigger (e.g. different history levels). label Aug 20, 2024
@yanavasileva yanavasileva self-assigned this Aug 20, 2024
@yanavasileva yanavasileva mentioned this pull request Aug 20, 2024
Closed
18 tasks
@yanavasileva yanavasileva added ci:all-db Runs the builds for all databases. ci:postgresql Runs the builds for the PostgreSQL database. and removed ci:default-build Runs the builds that have no explicit trigger (e.g. different history levels). ci:all-db Runs the builds for all databases. labels Aug 21, 2024
@yanavasileva yanavasileva changed the title remove(quarkus-extension): remove telemetry configuration property remove(tests): remove telemetry configuration property Aug 21, 2024
@yanavasileva
Copy link
Member Author

Re-assigning to @mboskamp, so we can merge the fix today.

@yanavasileva yanavasileva requested review from mboskamp and removed request for joaquinfelici August 23, 2024 06:46
mboskamp
mboskamp approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@mboskamp mboskamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Approved, but can you add more background info?

qa/test-old-engine/pom.xml Outdated Show resolved Hide resolved
...t/src/test/resources/org/camunda/bpm/quarkus/engine/test/config/mixed-application.properties Show resolved Hide resolved
@yanavasileva yanavasileva added the ci:no-build Prevents any CI stage from running. label Aug 23, 2024
@mboskamp mboskamp mentioned this pull request Aug 23, 2024
Merged
@yanavasileva yanavasileva merged commit abf8f55 into master Aug 23, 2024
2 checks passed
@yanavasileva yanavasileva deleted the 4483-telemetry-clean-quarkus branch August 23, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboskamp mboskamp mboskamp approved these changes

Assignees

@yanavasileva yanavasileva

Labels
ci:no-build Prevents any CI stage from running. ci:postgresql Runs the builds for the PostgreSQL database.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yanavasileva @mboskamp