fix(client) don't expose executionId to public API

related to: #4523
camunda · Sep 16, 2024 · 244f77f · 244f77f
1 parent f06cb96
commit 244f77f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 27 deletions.
diff --git a/clients/java/client/src/main/java/org/camunda/bpm/client/task/impl/ExternalTaskImpl.java b/clients/java/client/src/main/java/org/camunda/bpm/client/task/impl/ExternalTaskImpl.java
@@ -25,6 +25,7 @@
 import org.camunda.bpm.client.task.ExternalTask;
 import org.camunda.bpm.client.variable.impl.TypedValueField;
 import org.camunda.bpm.client.variable.impl.VariableValue;
+import org.camunda.bpm.client.variable.impl.value.DeferredFileValueImpl;
 import org.camunda.bpm.client.variable.value.DeferredFileValue;
 import org.camunda.bpm.engine.variable.VariableMap;
 import org.camunda.bpm.engine.variable.Variables;
@@ -258,8 +259,8 @@ public <T> T getVariable(String variableName) {
 
     VariableValue variableValue = receivedVariableMap.get(variableName);
     if (variableValue != null) {
-      if(variableValue.getTypedValue() instanceof DeferredFileValue) {
-        DeferredFileValue deferredFileValue = (DeferredFileValue) variableValue.getTypedValue();
+      if(variableValue.getTypedValue() instanceof DeferredFileValueImpl) {
+        DeferredFileValueImpl deferredFileValue = (DeferredFileValueImpl) variableValue.getTypedValue();
         deferredFileValue.setExecutionId(this.executionId);
       }
       value = (T) variableValue.getValue();
@@ -300,8 +301,8 @@ public <T extends TypedValue> T getVariableTyped(String variableName, boolean de
     VariableValue variableValue = receivedVariableMap.get(variableName);
     if (variableValue != null) {
       typedValue = variableValue.getTypedValue(deserializeObjectValues);
-      if(typedValue instanceof DeferredFileValue) {
-        DeferredFileValue deferredFileValue = (DeferredFileValue) typedValue;
+      if(typedValue instanceof DeferredFileValueImpl) {
+        DeferredFileValueImpl deferredFileValue = (DeferredFileValueImpl) typedValue;
         deferredFileValue.setExecutionId(this.executionId);
       }
     }

diff --git a/...lient/src/main/java/org/camunda/bpm/client/variable/impl/value/DeferredFileValueImpl.java b/...lient/src/main/java/org/camunda/bpm/client/variable/impl/value/DeferredFileValueImpl.java
@@ -80,20 +80,14 @@ public void setVariableName(String variableName) {
     this.variableName = variableName;
   }
 
-  @Override
   public void setExecutionId(String executionId){
     this.executionId = executionId;
   };
 
-  @Override
-  public String getExecutionId() {
-    return executionId;
-  }
-
   @Override
   public String toString() {
     return "DeferredFileValueImpl [mimeType=" + mimeType + ", filename=" + filename + ", type=" + type + ", "
-        + "isTransient=" + isTransient + ", isLoaded=" + isLoaded + ", processInstanceId" + processInstanceId + ", executionId" + executionId + "]";
+        + "isTransient=" + isTransient + ", isLoaded=" + isLoaded + "]";
   }
 
 }
diff --git a/...ts/java/client/src/main/java/org/camunda/bpm/client/variable/value/DeferredFileValue.java b/...ts/java/client/src/main/java/org/camunda/bpm/client/variable/value/DeferredFileValue.java
@@ -39,20 +39,4 @@ public interface DeferredFileValue extends FileValue {
    */
   boolean isLoaded();
 
-  /**
-   * Sets the executionId, which defines the scope of the DeferredFileValue.
-   * This identifier ensures that the correct scope is applied when loading the file value.
-   *
-   * @param executionId defines the scope of the DeferredFileValue
-   */
-  void setExecutionId(String executionId);
-
-  /**
-   * Returns the executionId, which specifies the scope of the DeferredFileValue.
-   * This identifier ensures that the correct scope is applied when loading the file value.
-   *
-   * @return the executionId which defines the scope of the DeferredFileValue
-   */
-  String getExecutionId();
-
 }