-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: merge zeebe-grpc to pyzeebe #549
Conversation
MR on gitlab - one week w/o response. |
Hi, can I help somehow ? Or is this already done? |
Pull Request Test Coverage Report for Build 12516152737Details
💛 - Coveralls |
Hi. I think it's done, need review. |
Will do, in the meantime should the generated files be excluded from coverage ? |
Yes, fixed |
Looks good on first impression, like the addition with the update.py. When does this get run, is it manually or during release/pre-commit ? |
Manually |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code itself is solid.
But I think we can now avaid using custom type classes like in grpc_internals/types.py
Co-authored-by: Felix Schneider <[email protected]>
I prefer don't expose transport types to clients. |
Ok, I suppose I know what you mean. Reason for this is the protobuf documentation of Message:
Which would provide everything we need, with the added benefit of not being independent from the generated classes, which could lead to uncatched incompatibilities between the generated classes and the custom type classes. PS. Will test this in #476 |
It's can be caught with mypy and tests (or issues). Clients should not know anything about the transport. And it will be the breaking change, w/o changing Messages. Any other comment? I would like to merge before NY. |
I think it's fine for now, happy merging. 🎆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this be 4.x.x or 5.x.x ? 🎆
4.x.x |
Merge zeebe-grpc to pyzeebe
Add mypy-stubs to bundled zeebe-grpc
Bump protobuf to 5.28 (breaking change?)
based on #476
close #475 close #476
cc @felicijus