rewrite realtime matching logic

[mbsalvatore]

Not sure how to deal with this section

//                    if (delay == null) {
//                        newTimes.updateArrivalTime(i, TripTimes.UNAVAILABLE);
//                        newTimes.updateDepartureTime(i, TripTimes.UNAVAILABLE);
//                    } else {
//                        newTimes.updateArrivalDelay(i, delay);
//                        newTimes.updateDepartureDelay(i, delay);
//                    }

maybe its ok to leave it out? not sure

[sheldonabrown]

Not sure how to deal with this section

//                    if (delay == null) {
//                        newTimes.updateArrivalTime(i, TripTimes.UNAVAILABLE);
//                        newTimes.updateDepartureTime(i, TripTimes.UNAVAILABLE);
//                    } else {
//                        newTimes.updateArrivalDelay(i, delay);
//                        newTimes.updateDepartureDelay(i, delay);
//                    }

maybe its ok to leave it out? not sure

I see your point. Delay is an alternative way to report the prediction. Ideally it would be treated identically to arrivalTime/departureTime. With that said, I don't believe any of the systems we currently integrate with use it so it is lower priority.