Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] partner_title_order: Migration to 18.0 #5

Closed

Conversation

Kimkhoi3010
Copy link

No description provided.

@@ -14,7 +14,7 @@ def test_default_order(self):
partner_titles = self.env["res.partner.title"].search([])
self.assertEqual(
partner_titles.mapped("name"),
partner_titles.sorted(lambda x: x.name).mapped("name"),
Copy link
Member

@TDu TDu Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this change because the test failed ?
Because it should not have, all sequence fields should have been set to 10 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good

@TDu
Copy link
Member

TDu commented Oct 11, 2024

@Kimkhoi3010 Could we move this to the oca repository, thank you

@Kimkhoi3010 Kimkhoi3010 reopened this Oct 11, 2024
@Kimkhoi3010 Kimkhoi3010 closed this by deleting the head repository Oct 14, 2024
@Kimkhoi3010
Copy link
Author

@TDu I updated by your comments, and created a new PR OCA#1862 to OCA/partner_contact.
(This PR was closed auto after rebased)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants