[16.0][FIX] logging_json: fix RecursionError #453
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Python 3.10, the use of
threading.currentThread()
is deprecated and generates a warning, and generating this warning log was in turn entering in thelogging_json
mechanism, triggering an exception:RecursionError: maximum recursion depth exceeded while calling a Python object
This error could be related to
queue.job
stuck in the stateStarted
on some projects (to confirm).EDIT: I confirm that this was blocking some jobs. I don't know why they weren't put in a
Failed
state but instead were still inStarted
, I didn't check.Traceback: