feat(DH): Add card last created #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Angi-Kinas
force-pushed
the
card-last-created
branch
from
532e990
to
11f0b3a
Compare
Angi-Kinas
commented
Jan 30, 2024
apps/datahub/src/app/common/results-list/results-list-grid/results-list-grid.component.ts
Outdated
Show resolved
Hide resolved
Angi-Kinas
commented
Jan 30, 2024
apps/datahub/src/app/common/results-list/results-list-grid/results-list-grid.component.html
Outdated
Show resolved
Hide resolved
Angi-Kinas
commented
Jan 30, 2024
.../common/results-list-item/results-card-last-created/results-card-last-created.component.html
Outdated
Show resolved
Hide resolved
Angi-Kinas
commented
Jan 30, 2024
.../common/results-list-item/results-card-last-created/results-card-last-created.component.html
Outdated
Show resolved
Hide resolved
tkohr
reviewed
Jan 31, 2024
apps/datahub/src/app/common/results-list/results-list-grid/results-list-grid.component.ts
Outdated
Show resolved
Hide resolved
tkohr
reviewed
Jan 31, 2024
.../common/results-list-item/results-card-last-created/results-card-last-created.component.html
Outdated
Show resolved
Hide resolved
Angi-Kinas
force-pushed
the
card-last-created
branch
from
02a56ff
to
82ed697
Compare
tkohr
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Thanks for the precise implementation @Angi-Kinas ! I've left some more comments inline.
.../common/results-list-item/results-card-last-created/results-card-last-created.component.html
Outdated
Show resolved
Hide resolved
| {{ record.abstract }} | ||
| </p> | ||
| </div> | ||
| <h1 class="font-bold text-[17px] line-clamp-2"> |
There was a problem hiding this comment.
Could it make sense to define a tailwind component for card titles, for example?
There was a problem hiding this comment.
Yes and no. In the favorite card the title is only supposed to be one line... that leaves only font-bold text-[17px] for the tailwind component. I don't know if it's worth the implementation.
...pp/common/results-list-item/results-card-last-created/results-card-last-created.component.ts
Outdated
Show resolved
Hide resolved
for mel-badge-button, finish styling card
from current project, adjust some design, use angular17 if and for, fix update search with routerFacade
add e2e tests for testing card on homepage
adapt style
Fix CI by adding geojson type to dev dependency
Angi-Kinas
force-pushed
the
card-last-created
branch
from
93db0c8
to
ab006b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the "results-card-last-created" for the homepage:
Clicking on the card leads you to the dataset details page. Clicking on the keyword, sets the search filter to the keyword.