[Dataset page]: Align content #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkohr
force-pushed
the
dataset-layout
branch
5 times, most recently
from
334b81d
to
927be3d
Compare
cmoinier
approved these changes
Feb 16, 2024
apps/datahub/src/app/dataset/dataset-header/dataset-header.component.html
Outdated
Show resolved
Hide resolved
tkohr
force-pushed
the
dataset-layout
branch
from
927be3d
to
b9532d8
Compare
Thanks for the review @cmoinier, good catch ! I've improved the templates regarding your two comments. |
cmoinier
approved these changes
Feb 19, 2024
tkohr
force-pushed
the
dataset-layout
branch
from
4a9d170
to
32d1f78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to align the content of the dataset page according to the mockups. The layout behaves responsively, without going too far into the details regarding this for now.
Note: The page's main content is not centered but aligned to the header content.