Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(DH): Change link to original metadata #19

Merged
merged 2 commits into from
Jun 17, 2024
Merged

chore(DH): Change link to original metadata #19

merged 2 commits into from
Jun 17, 2024

Conversation

Angi-Kinas
Copy link
Collaborator

Description

This PR introduces a change of the link inside of the metadata info that refers to the resource in geonetwork.
It also changes the translation for its label.

Screenshots

image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 17, 2024 •
edited
Loading

Affected libs: ui-elements, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, ui-catalog, ui-search,
Affected apps: metadata-editor, datahub, demo, webcomponents, map-viewer, search,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

jahow
jahow approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks! Have you checked that the URLs work well?

libs/ui/elements/src/lib/metadata-info/metadata-info.component.ts
@@ -90,6 +90,12 @@ export class MetadataInfoComponent {
return this.metadata.contactsForResource?.[0]
}

get metadataLandingPageAdvanced() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a // Geocat specific comment here? So that we keep track of changes :) thanks!

@Angi-Kinas
Copy link
Collaborator Author

@jahow Thanks for the review!
Yes I tested the url for at least the first 10 records and it worked :)

@Angi-Kinas Angi-Kinas merged commit 5d92423 into geocat Jun 17, 2024
5 checks passed
@Angi-Kinas Angi-Kinas deleted the DH-datahub-and-old-geocat-in-parallel branch June 17, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jahow jahow jahow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Angi-Kinas @jahow