Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification of the protocol and sink properties in the subscription… #418

Merged
merged 4 commits into from
Feb 19, 2025

Conversation

tlohmar
Copy link
Contributor

@tlohmar tlohmar commented Feb 16, 2025

… data model.

What type of PR is this?

  • correction

What this PR does / why we need it:

The protocol and the sink properties are not clearly defined. the URI-scheme of the sink value (an URL) shall follow the definition of the protocol value.

Which issue(s) this PR fixes:

Fixes #416

Does this PR introduce a breaking change?

  • Yes
  • No

Special notes for reviewers:

Changelog input

 release-note
Clarification of the protocol and sink properties within the subscription data model.

Additional documentation

This section can be blank.

docs

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
On behalf of @patrice-conil for Orange

PedroDiez
PedroDiez previously approved these changes Feb 18, 2025
Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

patrice-conil
patrice-conil previously approved these changes Feb 18, 2025
Copy link
Collaborator

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rartych
Copy link
Collaborator

rartych commented Feb 18, 2025

Resolved conflicts with #414

Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rartych rartych merged commit b720866 into camaraproject:main Feb 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage of HTTP (instead of HTTPS) in for notifications
5 participants