-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and rename CAMARA_common.json to CAMARA_common.yaml #107
Update and rename CAMARA_common.json to CAMARA_common.yaml #107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
@shilpa-padgaonkar: please see the linting results of a copy of the CAMARA_common.yaml in https://github.com/hdamker/QualityOnDemand/pull/4/files. There are some smaller issues which could easily be corrected. I propose to open an issue to introduce linting also in the Commonalities repo. |
|
@rartych : I have changed the link in design doc. If description needs to be changed, please create a new issue for it. |
@RubenBG7 @jordonezlucena As code owners, could you kindly review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ok from TEF side to PR 107 too |
Merging as agreed. |
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
changes json to yaml
extends file with device schema
conforms to oas
Which issue(s) this PR fixes:
Fixes #106 #201 #105
Special notes for reviewers:
Changelog input
Additional documentation
This section can be blank.