Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data converter] Improve the hex parsing & general functionality #2352

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

EclecticGriffin
Copy link
Collaborator

I spent some more time hacking on this instead of spending my time in a more productive way. This does the following:

  • switch the dat deserializing from custom matching stuff to a proper nom parser that accounts for comments and leading 0x tags.
  • dat files can now parse values with leading zeroes truncated (though we continue to generate dat files with the leading zeroes included)
  • Output dat files will be generated by default as MEMNAME.dat though this can be customized with -e flag. I.e. -e out will generate MEMNAME.out
  • Similarly, when reading in a dat directory, the tool will look for MEMNAME.dat which can be retargeted via -e flag.
  • The tool will also infer the --to json target when given a directory as input

Copy link
Contributor

@ekiwi ekiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks

@ekiwi ekiwi merged commit fa298e9 into main Nov 14, 2024
18 checks passed
@ekiwi ekiwi deleted the data-converter-hacking branch November 14, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants