-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Queues: convert to Python library #2274
Conversation
- Setup flit install - Tweak action to install queues pkg - Run test suite with runt
- alter CI to run gen script before runt tests - keep tests/binheap/binheap_test.{data, expect} (they're small)
- seperate pkg install and data gen into different jobs
- fix SDN tests - make binheap tests run
@anshumanmohan is it okay for me to move I think I remember you saying these files were artifacts for a different project. For this reason, I wanted to check if it's okay for me to move them around and tweak their associated |
Yay, thank you! Been looking forward to these changes haha. I will ask @csziklai and @KabirSamsi to glance over this PR and offer their own reviews if they’d like. It’s a great way to stay in the loop. Regardless, I’ll go through and review it tomorrow EoD |
Yes, that’s okay re: SDN! I’d like to resuscitate it and have it hang around somewhere, so just let me know where it ends up |
You can find it at I've made sure to alter the SDN runt stanzas so they point to this new location now. Those tests still pass just fine! |
wowowowow, this might be a record for deleted lines! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wowowow thanks for this massive massive cleanup! 👏 It's really looking a lot more organized and maintainable. I have reviewed this and learned a bunch from the process. Merge at will!
Closes #2186 and the test harness part of #2191.
More specifically, this PR does the following:
test/
data_gen/gen_queue_data_expect.sh
(for now)queues
for CI and rungen_queue_data_expect.sh
.data
and.expect
files