Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues: convert to Python library #2274

Merged
merged 9 commits into from
Sep 3, 2024
Merged

Queues: convert to Python library #2274

merged 9 commits into from
Sep 3, 2024

Conversation

polybeandip
Copy link
Collaborator

@polybeandip polybeandip commented Aug 29, 2024

Closes #2186 and the test harness part of #2191.

More specifically, this PR does the following:

  • set up separate directories for our package, data file generation, and tests
  • move each queue's python generator and associated main component to different files: main components are in test/
  • remove PCQs from data_gen/gen_queue_data_expect.sh (for now)
  • tweak runt stanzas to work with new file structure
  • tweak github actions to install queues for CI and run gen_queue_data_expect.sh
  • gitignore large .data and .expect files
  • fill in README for our library
  • update links in the docs to our new file locations and add install instructions

- Setup flit install
- Tweak action to install queues pkg
- Run test suite with runt
- alter CI to run gen script before runt tests
- keep tests/binheap/binheap_test.{data, expect} (they're small)
- seperate pkg install and data gen into different jobs
- fix SDN tests
- make binheap tests run
@polybeandip
Copy link
Collaborator Author

polybeandip commented Aug 29, 2024

@anshumanmohan is it okay for me to move sdn.py (and it's associated data and expect file)?

I think I remember you saying these files were artifacts for a different project. For this reason, I wanted to check if it's okay for me to move them around and tweak their associated runt stanza (not the cmd part, only path).

@anshumanmohan
Copy link
Contributor

Yay, thank you! Been looking forward to these changes haha. I will ask @csziklai and @KabirSamsi to glance over this PR and offer their own reviews if they’d like. It’s a great way to stay in the loop. Regardless, I’ll go through and review it tomorrow EoD

@anshumanmohan
Copy link
Contributor

Yes, that’s okay re: SDN! I’d like to resuscitate it and have it hang around somewhere, so just let me know where it ends up

@polybeandip
Copy link
Collaborator Author

You can find it at frontends/queues/tests/sdn_test.py.

I've made sure to alter the SDN runt stanzas so they point to this new location now. Those tests still pass just fine!

@EclecticGriffin
Copy link
Collaborator

wowowowow, this might be a record for deleted lines!

Copy link
Contributor

@anshumanmohan anshumanmohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wowowow thanks for this massive massive cleanup! 👏 It's really looking a lot more organized and maintainable. I have reviewed this and learned a bunch from the process. Merge at will!

.github/workflows/rust.yml Show resolved Hide resolved
docs/frontends/queues.md Show resolved Hide resolved
frontends/queues/queues/strict_or_rr.py Show resolved Hide resolved
@polybeandip polybeandip merged commit dfb40da into main Sep 3, 2024
18 checks passed
@polybeandip polybeandip deleted the queue-lib branch September 3, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Queues: convert to Python library
4 participants