On Mac, restore original preferences after replay. #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does it work when the replay had an error and stopped early? Does it work if the replay ran to completion without quitting the game? (Though the latter seems like it might not be possible, unless you manually craft a replay file.) |
|
In the latter case (which is definitely possible, if you use Ctrl+C on the command line), it does restore the preferences but only after you close the window manually. |
|
In order to make this bullet-proof I think the way to go would be to make the windows/linux implementation of the preferences available to the Mac build when running in replay mode. Because otherwise, the Mac code isn't equipped to store the multi-type preference things in a std::map. |
|
I think I'll do it the other way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #456
(I tested this and it works.)