Keys can shift the screen #537
Conversation
rsrc/dialogs/preferences.xml
Outdated
| @@ -43,6 +43,7 @@ | |||
| </group> | |||
| <text name='misc-head' size='large' relative='pos-in pos' anchor='spd-head' top='30' left='0' width='182' height='17'>Miscellaneous:</text> | |||
| <led name='nosound' relative='pos-in pos' anchor='misc-head' top='6' left='15'>No Sounds</led> | |||
| <led name='keyshift' relative='pos-in pos' rel-anchor='prev' top='10' left='0'>Directional keys can shift the screen</led> | |||
There was a problem hiding this comment.
I think this should make it more clear that it's swapping one capability with another. Something like "Directional keys shift… instead of…".
There was a problem hiding this comment.
How about this?
There was a problem hiding this comment.
Better, but I think a different word than "squares" should be used. Maybe "tiles" or "spaces"?
And I didn't check what you set the default to be, but right now I think it should default to the legacy behaviour.
There was a problem hiding this comment.
@CelticMinstrel What if holding shift or option/alt performed the opposite function so both are always available?
There was a problem hiding this comment.
The dialog could have a parenthetical text explaining this
There was a problem hiding this comment.
Sure, why not. The only question would be which modifier to pick… what precedent do we have so far? There's also the option of Control/Command (that is, Command on Mac, Control on non-Mac).
Given how "shift" typically means "extend", it seems like that doesn't really fit this kind of use. I guess "alt" fits better. Not sure whether "control" fits.
There was a problem hiding this comment.
replied to this out-of-thread (as a new comment)
NQNStudios
force-pushed
the
screen-shift-keys
branch
from
6d953d8 to
ead987f
Compare
|
Hmm. I currently have it implemented it with Shift, which might make less sense but is functional. Just now I tried changing it to Alt/Option, and ran into a problem. Targeting for Look mode is already checking for the Option key, which makes Look Target mode stay activated after targeting a spot. |
This makes it so arrow keys/numpad can control screen shift when it's available.
When this preference is enabled, #482 will not be an issue (Fix #482). But the player will also miss out on cases where adjacent targeting would be a good thing. I haven't done anything smart to determine whether one mode or the other is better on a case-by-case basis.