[WIP] View access #130
Open
[WIP] View access #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfekadu
reviewed
Apr 8, 2020
Entity/ProfessorSectionView.py
Outdated
|
|
||
|
|
||
| class ProfessorSectionView(Base): | ||
| __tablename__ = "Professor_Teaches_Section_2" |
There was a problem hiding this comment.
I believe Professor_Teaches_Section_2 was a by product of me exploring the CREATE VIEW syntax in SQL.
Let's consider Professor_Teaches_Section to be the official __tablename__
There was a problem hiding this comment.
Fixed and tested
Changed from "Professor_Teaches_Section_2" to "Professor_Teaches_Section"
zpdeng
approved these changes
Apr 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's New?
Added access to the Professor_Teaches_Section_View_2
See: Issue #129
Type of change (pick-one)
How Has This Been Tested?
running _get_property_from_entity() on the Professors table and Professor_Teaches_Section_2 view.
Checklist (check-all-before-merge)
formatting help:
- [x]means "checked' and- [ ]means "unchecked"I documented my code according to the Google Python Style Guide
I ran
./build_docs.shand the docs look fineI ran
./type_check.shand got no errorsI ran
./format.shbecause it automatically cleans my code for me 😄I ran
./lint.shto check for what "format" missedI added my tests to the
/testsdirectoryI ran
./run_tests.shand all the tests pass