Skip to content

feat: rewrite to ShadowNodes (again...) #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

okwasniewski
Copy link
Collaborator

PR Description

This PR rewrites the logic to use shadow nodes in order to mitigate the blank frame issue that's happening currently when the available space needs to be measured in order for the components to be rendered.

TODO:

  • Android

- Added useMemo for routes array with hideOneTab dependency

- Added useMemo for renderScene to prevent unnecessary recreations

- Created memoized navigationState object that only updates when index
or routes change

- This optimization prevents unnecessary re-renders when the component
updates

Signed-off-by: Oskar Kwaśniewski <[email protected]>
Copy link

changeset-bot bot commented Mar 20, 2025

⚠️ No Changeset found

Latest commit: 3b34081

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@okwasniewski okwasniewski force-pushed the feat/measurements branch 2 times, most recently from 462a9fd to 4a56cf5 Compare March 20, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant